Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

container-structure-test: init at 1.18.1 #316449

Merged
merged 2 commits into from
Jul 2, 2024
Merged

container-structure-test: init at 1.18.1 #316449

merged 2 commits into from
Jul 2, 2024

Conversation

rubenhoenle
Copy link
Contributor

@rubenhoenle rubenhoenle commented Jun 1, 2024 •
edited
Loading

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Jun 1, 2024
@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 1, 2024
@rubenhoenle
Copy link
Contributor Author

tested basic functionality with https://github.com/rubenhoenle/container-structure-test-example

@rubenhoenle rubenhoenle changed the title feat(nixpkgs): add google container-structure-test package container-structure-test: init at 1.18.1 Jun 1, 2024
@rubenhoenle rubenhoenle requested a review from Noodlez1232 June 4, 2024 12:27
Noodlez1232
Noodlez1232 approved these changes Jun 8, 2024
View reviewed changes
Copy link
Contributor

@Noodlez1232 Noodlez1232 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, and it looks good to me!

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jun 10, 2024
@0x4A6F
Copy link
Member

0x4A6F commented Jun 10, 2024

Result of nixpkgs-review pr 316449 run on x86_64-linux 1

1 package built:
  • container-structure-test

@rubenhoenle rubenhoenle requested a review from Golo300 June 18, 2024 17:26
@wegank wegank added 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Jun 20, 2024
@0x4A6F 0x4A6F merged commit 260f801 into NixOS:master Jul 2, 2024
25 of 27 checks passed
@rubenhoenle rubenhoenle mentioned this pull request Oct 25, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aleksanaa Aleksanaa Aleksanaa left review comments

@0x4A6F 0x4A6F 0x4A6F approved these changes

@Golo300 Golo300 Golo300 approved these changes

@Noodlez1232 Noodlez1232 Noodlez1232 approved these changes

Assignees
No one assigned
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@rubenhoenle @0x4A6F @Noodlez1232 @Aleksanaa @Golo300 @wegank @NixOSInfra